Translation fix in studio: For better translation in unit.html - #3121
Merged
Conversation
louyihua
changed the title
Contributor
|
@cahrens or @andy-armstrong, could one of you review this? |
Contributor
|
Thanks for looking into this. This looks like an improvement, but my preference would be to remove all string splicing entirely. I would instead have two translation strings for the entire sentence, i.e. something like: I think this gives the translators the most freedom. Does that seem reasonable? |
There was a problem hiding this comment.
I would worry that the translators will mess up the space (the fact that release_date_string ends with a space). They will either leave off the trailing space on release_date_string, or add an extra space in this sentence. I think it would be less error-prone to go back to the if/else approach.
As the sentence in unit.html is splitted into three parts due to the varible release_date may be None, it breaks the integrity of a sentence. Different language may have different word or event grammer order, so if a sentence is breaked into three parts, translators cannot adjust the word orders to create a good translation. So this fix tries to combine the sentence together.
Contributor
Author
|
@andy-armstrong OK, I just changed it to two sentences. |
Contributor
andy-armstrong
added a commit
that referenced
this pull request
Mar 31, 2014
Translation fix in studio: For better translation in unit.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the sentence in unit.html is splitted into three parts due to the varible release_date may be None, it breaks the integrity of a sentence.
Different language may have different word or event grammer order, so if a sentence is breaked into three parts, translators cannot adjust the word orders to create a good translation.
This fix tries to combine the sentence together so that translators can freely change the orders of sentence parts to make a good translation.